Complete card payment only after alert presentation is done #15967
+57
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isEligibleForBackendReceipts is async resulting in onPaymentCompletion called before alert presentation is done. This causes CardPresentPaymentCollectOrderPaymentUseCaseAdaptor to deinitialize CollectOrderPaymentUseCase before payment success is shown resulting in card payment stuck at processing step.
Collaborator
Collaborator
|
|
1 task
jaclync
approved these changes
Jul 31, 2025
Contributor
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
LGTM! 
Thanks a lot for looking into the root cause and fixing it properly. I tested in a simulator with simulated card reader enabled, and a physical device with a card reader, for successful payments in both POS and IPP without getting stuck.
| } | ||
|
|
||
| // Then ensure payment completion happens after alert presentation to avoid CollectOrderPaymentUseCase deinit before alert presentation | ||
| XCTAssertEqual(eventOrder, [.receiptEligibilityCheck, .alertPresented, .paymentCompletion]) |
Contributor
There was a problem hiding this comment.
Nice way of testing this 👍
Contributor
|
Merging this now to post about releasing a new beta, cc @RafaelKayumov. |
jaclync
deleted the
woomob-953-woo-pos-card-payments-are-not-succeeding-on-229-beta
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOMOB-953
Description
As @jaclync has noticed when doing PR Review for #15956 the card payments would succeed, but POS was left stuck in "Processing..." screen.
Investigation
I tested TestFlight versions and confirmed that the issue wasn't reproducible on 22.8 but was reproducible on the current beta, 22.9.
I couldn't pinpoint an issue by looking at the changes so I did a
git bisectthat pointed to this commit.What this small change did was expose a slight timing issue when
onPaymentCompletion()was called.onPaymentCompletion()was relying onisEligibleForBackendReceiptscheck being synchronous, so alert presentation would be called before payment completion. However, after this commit,isEligibleForBackendReceiptsbecame asynchronous, and alert presentation was called afteronPaymentCompletion().It didn't cause issues for IPP because of the different ways
CollectOrderPaymentUseCasewas used. For POS,CardPresentPaymentCollectOrderPaymentUseCaseAdaptorwould deinitializeCollectOrderPaymentUseCaseafter a successful payment. Therefore, alert presenters were never called to notify about successful paymentSolution
The solution is straightforward. Move
onPaymentCompletion()intoisEligibleForBackendReceiptsto ensure alert presenters are called before completing the payment.I also added a test to ensure the expected event order.
Steps to reproduce
Testing information
RELEASE-NOTES.txtif necessary.